Update PJRT plugin API version to 0.57 #19241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
force-pushed
the
update-pjrt-api
branch
from
8d30668 to
676960a
Compare
Signed-off-by: PragmaTwice <twice@apache.org>
PragmaTwice
force-pushed
the
update-pjrt-api
branch
2 times, most recently
from
8e96573 to
cd195e2
Compare
PragmaTwice
requested review from
ScottTodd,
benvanik and
stellaraccident
as code owners
Signed-off-by: PragmaTwice <twice@apache.org>
PragmaTwice
force-pushed
the
update-pjrt-api
branch
from
cd195e2 to
1993cb5
Compare
Signed-off-by: PragmaTwice <twice@apache.org>
ScottTodd
approved these changes
Nov 25, 2024
Comment on lines
+2167
to
+2170
| // PJRT_Plugin_Attributes should be implemented since it will always be | ||
| // called from the PJRT client in the initial phase. | ||
| // here we provide a blank implementation to avoid crash due to unimplemented. | ||
| api->PJRT_Plugin_Attributes = |
There was a problem hiding this comment.
Ah, classic. An internal bug link for API documentation.
openxla/xla@619ca7b
// Returns an array of plugin attributes which are key-value pairs. One example
// attribute is the minimum supported StableHLO version.
// TODO(b/280349977): standardize the list of attributes.
typedef PJRT_Error* PJRT_Plugin_Attributes(PJRT_Plugin_Attributes_Args* args);Fine to implement as you have it here for now.
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
It closes iree-org#19223. `integrations/pjrt/third_party/pjrt_c_api/xla/pjrt/c/pjrt_c_api.h` is updated to the latest (with API version from 0.38 to 0.57), fetching from https://github.com/openxla/xla/blob/a454e14ab0b10e35fb8ad73bd6db7d93782114f6/xla/pjrt/c/pjrt_c_api.h. A blank implementation of `PJRT_Plugin_Attributes` is now provided since an unimplemented `PJRT_Plugin_Attributes` will lead to initialization failure of PJRT plugin (and thus crashes) in recent versions of PJRT clients. Also the JAX version in the CI workflow is updated from 0.4.20 to 0.4.35 and subsequently more tests can be enabled. ci-exactly: build_packages, test_pjrt --------- Signed-off-by: PragmaTwice <twice@apache.org>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
It closes iree-org#19223. `integrations/pjrt/third_party/pjrt_c_api/xla/pjrt/c/pjrt_c_api.h` is updated to the latest (with API version from 0.38 to 0.57), fetching from https://github.com/openxla/xla/blob/a454e14ab0b10e35fb8ad73bd6db7d93782114f6/xla/pjrt/c/pjrt_c_api.h. A blank implementation of `PJRT_Plugin_Attributes` is now provided since an unimplemented `PJRT_Plugin_Attributes` will lead to initialization failure of PJRT plugin (and thus crashes) in recent versions of PJRT clients. Also the JAX version in the CI workflow is updated from 0.4.20 to 0.4.35 and subsequently more tests can be enabled. ci-exactly: build_packages, test_pjrt --------- Signed-off-by: PragmaTwice <twice@apache.org> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #19223.
integrations/pjrt/third_party/pjrt_c_api/xla/pjrt/c/pjrt_c_api.his updated to the latest (with API version from 0.38 to 0.57), fetching from https://github.com/openxla/xla/blob/a454e14ab0b10e35fb8ad73bd6db7d93782114f6/xla/pjrt/c/pjrt_c_api.h.A blank implementation of
PJRT_Plugin_Attributesis now provided since an unimplementedPJRT_Plugin_Attributeswill lead to initialization failure of PJRT plugin (and thus crashes) in recent versions of PJRT clients.Also the JAX version in the CI workflow is updated from 0.4.20 to 0.4.35 and subsequently more tests can be enabled.
ci-exactly: build_packages, test_pjrt