Let ConvertToROCDL use MathToROCDL, not MathToLLVM #19994
Draft
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
krzysz00
reviewed
Feb 18, 2025
| @@ -217,7 +217,6 @@ struct ConvertToROCDLPass final | |||
| populateLowerHALInterfaceOp(llvmPatterns); | |||
| populateLLVMConversionPatterns(&getContext(), llvmPatterns, converter); | |||
| populateComplexToLLVMConversionPatterns(converter, llvmPatterns); | |||
| populateMathToLLVMConversionPatterns(converter, llvmPatterns); | |||
There was a problem hiding this comment.
You won't want to get rid of this since this has patterns that the device libraries don't - that is, MathToROCDL only includes things that don't get covered by MathToLLVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this makes any difference. It's just something I stumbled upon, that seemed possibly unintentional.