[stream] Dedeplicate stream.yield values from stream.async.execute
#20056
+96
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
force-pushed
the
dedupe_async
branch
2 times, most recently
from
a80c055 to
7e6abff
Compare
benvanik
reviewed
Feb 24, 2025
| auto yield = | ||
| cast<IREE::Stream::YieldOp>(op.getBody().front().getTerminator()); | ||
| int64_t oldYieldCount = yield.getResourceOperands().size(); | ||
| for (int i = 0, s = oldYieldCount; i < s; ++i) { |
There was a problem hiding this comment.
style/warnings: use consistent types - oldYieldCount is int64_t so you'd use int64_t here - but really, size() is size_t so oldYieldCount and i/s here should be size_t
(some compilers care about this more than others especially if signedness changes, but it also helps readability)
| auto newExecuteOp = rewriter.create<IREE::Stream::AsyncExecuteOp>( | ||
| op.getLoc(), newTypes, newResultSizes, op.getAwaitTimepoint(), | ||
| op.getResourceOperands(), op.getResourceOperandSizes(), | ||
| llvm::SmallVector<int64_t>()); |
There was a problem hiding this comment.
we'll need to preserve tied operands - this is stripping them all
(always useful to throw in a tied operand to ensure they are not stripped, like by adding a ..., %tied) -> %tied to the end so that it's clear the indices are updated properly - updating index 0 tied operands is usually too easy :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If during cleanup values are replicated in
stream.async.executecases it can result in double allocation of those blocks (this occurs as ScheduleAllocation assumes all returns are unique). This double allocation also results in bad numerical behavior as the separate returns may be used by different dispatches and fetch incorrect values.