[python] Fix immediate mode scheduling of BuildActions in iree.build #20142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sogartar
force-pushed
the
fix-iree-build-action-immediate-mode
branch
from
33c07bb to
6f11b62
Compare
When running the build action in the same thread we must still do a start finish to get an initialized completed future. Signed-off-by: Boian Petkantchin <boian.petkantchin@amd.com>
sogartar
force-pushed
the
fix-iree-build-action-immediate-mode
branch
from
6f11b62 to
26bfb49
Compare
geomin12
pushed a commit
to geomin12/iree
that referenced
this pull request
Mar 5, 2025
…ree-org#20142) When running the build action in the same thread we must still do a start-finish to get an initialized completed future. Signed-off-by: Boian Petkantchin <boian.petkantchin@amd.com> Signed-off-by: geomin12 <geomin12@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the build action in the same thread we must still do a start-finish to get an initialized completed future.