chore: makes country code mandatory

iris-connect · Mar 4, 2022 · 8a9d5e8 · 8a9d5e8
1 parent 13dd2e8
commit 8a9d5e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/iris-client-bff/src/main/java/iris/client_bff/core/validation/PhoneNumber.java b/iris-client-bff/src/main/java/iris/client_bff/core/validation/PhoneNumber.java
@@ -42,7 +42,7 @@ public boolean isValid(final String text, final ConstraintValidatorContext conte
 
 			try {
 
-				var number = util.parse(text, "DE");
+				var number = util.parse(text, "ZZ");
 				return util.isValidNumber(number);
 
 			} catch (NumberParseException e) {

diff --git a/iris-client-bff/src/test/java/iris/client_bff/core/validation/PhoneNumberTests.java b/iris-client-bff/src/test/java/iris/client_bff/core/validation/PhoneNumberTests.java
@@ -27,9 +27,8 @@ class PhoneNumberTests {
 
 	@ParameterizedTest(name = "\"{0}\"")
 	@ValueSource(
-			strings = { "035156789", "(0351) 56789", "+49 351 67833", "+4935112345678", "+49 351/12345678",
-					"+49 (351) 12345678", "0172 11156789", "0172/11156789", "0222 6578-22", "0351A56789", "+61403123456",
-					"+43 316 787 400" })
+			strings = { "+49 351 67833", "+4935112345678", "+49 351/12345678", "+49 (351) 12345678", "+49172 11156789",
+					"+49/172/11156789", "+61403123456", "+43 316 787 400" })
 	@DisplayName("with valide value")
 	void validate_withValidValue_getNoViolations(String value) {
 
@@ -39,8 +38,9 @@ void validate_withValidValue_getNoViolations(String value) {
 	}
 
 	@ParameterizedTest(name = "\"{0}\"")
-	@ValueSource(strings = { "", "0351%56789", "0351 473+11", "0123456*89", "0", "1234567", "0172 111567"/*to short*/,
-			"+49 12345 67833" /*prefix invalid*/ })
+	@ValueSource(strings = { "", "+49351%56789", "+49 351 473+11", "+49123456*89", "0", "1234567",
+			"+49172 111567"/*to short*/, "+49 12345 67833" /*area code invalid*/, "035156789" /*missing country code*/,
+			"(0351) 56789", "0172 11156789", "0172/11156789", "0222 6578-22", "0351A56789" })
 	@DisplayName("with invalide value")
 	void validate_withInvalidValue_getViolations(String value) {