feat(vaccination report): Apps connected to EPS can announce the submis… #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error and exception handling are not yet implemented coherently. |
jekutzsche
force-pushed
the
feature/BL273-Announce_Vaccination_Info_List
branch
from
5e337f8 to
d5add1a
Compare
…sion of vaccination information lists via the JSON-RPC method `announceVaccinationInfoList`. A transmission channel is then opened briefly for the respective user of the app. Refs iris-connect/iris-backlog#273
… job - Adds a job to delete old announcements. - Externalize the configuration of the expiration time to a properties class.
* Adds validation for Base64 values. * Adds domain exceptions. * Adds an extension for JUnit5 to simplify tests of constraints and Validators.
jekutzsche
force-pushed
the
feature/BL273-Announce_Vaccination_Info_List
branch
from
b6feb38 to
412e145
Compare
lucky-lusa
reviewed
Mar 3, 2022
| announcement_token varchar(256) NULL, | ||
| created datetime NOT NULL, | ||
| last_modified datetime NOT NULL, | ||
| created_by binary(16) NULL, |
There was a problem hiding this comment.
Since this is not created by an account, shouldnt we just kick out those fields?
There was a problem hiding this comment.
I find it more problematic to use an abstraction here that differs from the other places than to have the two or three columns in addition. created also makes sense here. The data is automatically managed by the framework anyway.
In the context of the audit log we could think about using the passed client name as principal for the calls by the EPS and then using it as author.
There was a problem hiding this comment.
Then lets use the client name to utilize the fields. I am not a big fan of having unused code (that should match your views, as far as I know).
There was a problem hiding this comment.
In principle I agree, but here I prefer a uniform approach and recognition in the code. To an aggregate belong these four metadata and that is an abstraction. You don't have to deal with three different possibilities. Three de facto unused columns weigh less heavily for me.
There was a problem hiding this comment.
I'll look at getting the client name in there after I finish the API. I think that's a sensible idea in general.
jekutzsche
changed the title
lucky-lusa
approved these changes
Mar 7, 2022
jekutzsche
pushed a commit
that referenced
this pull request
Mar 9, 2022
# [1.5.0-rc.1](v1.4.1...v1.5.0-rc.1) (2022-03-09) ### Bug Fixes * Adds grpc server to client EPS. Still not reachable from outside, but necessary for communication between health departments. ([679c08e](679c08e)), closes [#637](#637) * Fixes an error when changing user data (IllegalStateException: Cannot convert value of type 'java.lang.String' […] no matching editors or conversion strategy found). ([58b3d42](58b3d42)) ### Features * Adds a hint to search for hd-contacts by postal code or city into the message input frontend. ([032a648](032a648)), closes [#632](#632) [#636](#636) * Displays meta-data (who and when created/last modified an entity) on event-tracking, index-tracking and user detail pages. ([da1b7a6](da1b7a6)), closes [iris-connect/iris-backlog#234](https://github.com/iris-connect/iris-backlog/issues/234) [#638](#638) * **vaccination report:** Apps connected to EPS can announce the submission of a vaccination report via the JSON-RPC method `announceVaccinationInfoList`. A transmission channel is then opened briefly for the respective user of the app. ([c38078a](c38078a)), closes [iris-connect/iris-backlog#273](https://github.com/iris-connect/iris-backlog/issues/273) [#635](#635) * **vaccination report:** Apps connected to EPS can submit a vaccination report via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. ([72b1f74](72b1f74)), closes [iris-connect/iris-backlog#274](https://github.com/iris-connect/iris-backlog/issues/274) [#651](#651) * **vaccination report:** There is a new view in the front end with an overview of submitted vaccination reports. In the details view of a vaccination report, the submitted persons are displayed with their vaccination status. ([00e93e8](00e93e8)), closes [iris-connect/iris-backlog#275](https://github.com/iris-connect/iris-backlog/issues/275) [#629](#629)
|
🎉 This PR is included in version 1.5.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jekutzsche
pushed a commit
that referenced
this pull request
Mar 16, 2022
# [1.5.0](v1.4.1...v1.5.0) (2022-03-16) ### Bug Fixes * Adds grpc server to client EPS. Still not reachable from outside, but necessary for communication between health departments. ([679c08e](679c08e)), closes [#637](#637) * Fixes an error when changing user data (IllegalStateException: Cannot convert value of type 'java.lang.String' […] no matching editors or conversion strategy found). ([58b3d42](58b3d42)) ### Features * Adds a hint to search for hd-contacts by postal code or city into the message input frontend. ([032a648](032a648)), closes [#632](#632) [#636](#636) * Displays meta-data (who and when created/last modified an entity) on event-tracking, index-tracking and user detail pages. ([da1b7a6](da1b7a6)), closes [iris-connect/iris-backlog#234](https://github.com/iris-connect/iris-backlog/issues/234) [#638](#638) * **Docker Compose:** Adds scope labels to the services in the Docker Compose file to avoid conflicts with possibly existing other instances of Watchtower on the same Docker host. ([499267f](499267f)), closes [#666](#666) * **Messages:** Uses `_ping` and the EPS version check when building the recipient list to determine if a health department is able to receive messages. This avoids additional configuration and enables faster propagation of the feature. ([446da17](446da17)), closes [#668](#668) * **vaccination report:** Apps connected to EPS can announce the submission of a vaccination report via the JSON-RPC method `announceVaccinationInfoList`. A transmission channel is then opened briefly for the respective user of the app. ([c38078a](c38078a)), closes [iris-connect/iris-backlog#273](https://github.com/iris-connect/iris-backlog/issues/273) [#635](#635) * **vaccination report:** Apps connected to EPS can submit a vaccination report via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. ([72b1f74](72b1f74)), closes [iris-connect/iris-backlog#274](https://github.com/iris-connect/iris-backlog/issues/274) [#651](#651) * **vaccination report:** There is a new view in the front end with an overview of submitted vaccination reports. In the details view of a vaccination report, the submitted persons are displayed with their vaccination status. ([00e93e8](00e93e8)), closes [iris-connect/iris-backlog#275](https://github.com/iris-connect/iris-backlog/issues/275) [#629](#629)
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sion of a vaccination report via the JSON-RPC method
announceVaccinationInfoList. A transmission channel is then opened briefly for the respective user of the app.Refs iris-connect/iris-backlog#273