fix(HD Search): adds getAllHds and improves the performance of the …
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HD search with `searchForHd` - Adds the boolean param `withDetails` to the method `searchForHd` to switch between a basic and a full data view. The basic view contains only `name`, `rkiCode` and `epsName`. - Adds the boolean param `alsoNotConnectedHds` to the method `searchForHd` to enable if the hds without an `epsName` (these are not connected to EPS) include into the response list or not. - Adds the method `getAllHds` to get a list of all infos about health departments from RKI data. This method has also the parameter `withDetails` and `alsoNotConnectedHds`. When reading data from the RKI XML with XML Beam, each read costs time and the less data that needs to be read/fetched, the faster the search and processing goes. Therefore, the processing can be accelerated very significantly with the two parameters. **It should always be loaded as little data as possible and best both parameters should be set to FALSE. Further optimizations were made in the code to load data from the XML only once and only when it is really needed. Refs iris-connect/iris-client#678
lucky-lusa
approved these changes
Mar 21, 2022
jekutzsche
changed the title
getAllHds and improves the pervormance of the …getAllHds and improves the performance of the …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…HD search with
searchForHdwithDetailsto the methodsearchForHdto switch between a basic and a full data view. The basic view contains onlyname,rkiCodeandepsName.alsoNotConnectedHdsto the methodsearchForHdto enable if the hds without anepsName(these are not connected to EPS) include into the response list or not.getAllHdsto get a list of all infos about health departments from RKI data. This method has also the parameterwithDetailsandalsoNotConnectedHds.When reading data from the RKI XML with XML Beam, each read costs time and the less data that needs to be read/fetched, the faster the search and processing goes. Therefore, the processing can be accelerated very significantly with the two parameters.
**It should always be loaded as little data as possible and best both parameters should be set to FALSE.
Further optimizations were made in the code to load data from the XML only once and only when it is really needed.
Refs iris-connect/iris-client#678