pythongh-106360: remove redundant #ifdef

iritkatriel · Jul 11, 2023 · bb717b9 · bb717b9
1 parent 1f2921b
commit bb717b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/Python/opcode_metadata.h b/Python/opcode_metadata.h
diff --git a/Tools/cases_generator/generate_cases.py b/Tools/cases_generator/generate_cases.py
@@ -1240,7 +1240,7 @@ def write_metadata(self) -> None:
  self.out.emit("extern const struct opcode_metadata _PyOpcode_opcode_metadata[512];")
  self.out.emit("extern const struct opcode_macro_expansion _PyOpcode_macro_expansion[256];")
  self.out.emit("extern const char * const _PyOpcode_uop_name[512];")
- self.out.emit("#else")
+ self.out.emit("#else // if NEED_OPCODE_METADATA")
 
  self.out.emit("const struct opcode_metadata _PyOpcode_opcode_metadata[512] = {")
 
@@ -1289,12 +1289,10 @@ def write_metadata(self) -> None:
  case _:
  typing.assert_never(thing)
 
- self.out.emit("#ifdef NEED_OPCODE_METADATA")
  with self.out.block("const char * const _PyOpcode_uop_name[512] =", ";"):
  self.write_uop_items(lambda name, counter: f"[{counter}] = \"{name}\",")
- self.out.emit("#endif // NEED_OPCODE_METADATA")
 
- self.out.emit("#endif")
+ self.out.emit("#endif // NEED_OPCODE_METADATA")
 
  with open(self.pymetadata_filename, "w") as f:
  # Create formatter