[feature/OPT-1029] to dev #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmgarcia-iriusrisk
requested changes
Oct 24, 2023
There was a problem hiding this comment.
@smaneroiriusrisk nice work! Great idea how uniting components and trustzone in the same list works!
I wrote a couple of comments I'd like to discuss before approving this PR.
| from slp_drawio.slp_drawio.parse.tranformers.parent_calculator_transformer import ParentCalculatorTransformer | ||
|
|
||
|
|
||
| class TestParentCalculatorTransformer: |
There was a problem hiding this comment.
This class lacks tests to set the parent for:
- Component has a TrustZone as parent
- Trustzone has a Component as a parent
- Trustzone has another TZ as a parent
There was a problem hiding this comment.
I think these use cases are out of scope of the MVP, but I have done it anyway. I had to modify the DiagramTrustzone class.
| return PARENT_TYPES[element.__class__] | ||
|
|
||
|
|
||
| class ParentCalculatorTransformer(Transformer): |
There was a problem hiding this comment.
Parent calculator should be used at DrawioParser.build_otm bellow the line # TODO Implement and call Transformers here
There was a problem hiding this comment.
I'm not sure if this is the right task to do that, but also done anyway
jmgarcia-iriusrisk
previously approved these changes
Oct 24, 2023
dantolin-iriusrisk
previously approved these changes
Oct 24, 2023
jmgarcia-iriusrisk
dismissed stale reviews from dantolin-iriusrisk and themself
via
48b24b4
jmgarcia-iriusrisk
approved these changes
Oct 24, 2023
dantolin-iriusrisk
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.