Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some unit tests now fail since merging PR #67 #68

Closed
irmen opened this issue May 15, 2019 · 0 comments
Closed

some unit tests now fail since merging PR #67 #68

irmen opened this issue May 15, 2019 · 0 comments
Labels

Comments

@irmen
Copy link
Owner

irmen commented May 15, 2019

Since merging PR #67 four unit tests now fail @adamsitnik I'll have a quick look myself too

Seems all 4 fails are caused by something that broke that now incorrectly unpickles into an arraylist where it had to be a hashset.

I think

is the important one here and that will likely fix the other errors as well.

See https://travis-ci.org/irmen/Pyrolite/jobs/532987059

edit: actually managed to get the Travis CI build running with BOTH Java AND Dotnet unit tests this time (was only doing Java before)

@irmen irmen added the bug label May 15, 2019
@irmen irmen closed this as completed in d97aa7b May 15, 2019
irmen added a commit that referenced this issue May 15, 2019
make sure hash sets are handled properly, fixes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant