Skip to content

Implement env variable for altering the default query limit in genquery #712 #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulborgermans
Copy link
Contributor

See #712

Unverified

This user has not yet uploaded their public signing key.
@alanking alanking requested a review from d-w-moore April 21, 2025 13:20
@d-w-moore
Copy link
Collaborator

d-w-moore commented Apr 28, 2025

Would we like this to be implemented in terms of @korydraughn's suggestion (#712 (comment)), that is as part of the client configuration

If we do it that way, it comes with a free (albeit more verbosely named) environment variable ; ) ... in other words, use of the config file per se is not required.

@korydraughn
Copy link
Contributor

Let's use the mechanisms provided by the PRC. Other configuration properties are managed by that file and adding another sounds like the correct path forward.

As you said, the environment variable becomes free as well.

@d-w-moore Does that align with the original goal of the client config mechanism?

@d-w-moore
Copy link
Collaborator

Let's use the mechanisms provided by the PRC. Other configuration properties are managed by that file and adding another sounds like the correct path forward.

As you said, the environment variable becomes free as well.

@d-w-moore Does that align with the original goal of the client config mechanism?

Yes. I'll modify as necessary

@alanking
Copy link
Contributor

FYI: New work is in #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants