[#709] preserve options in chaining obj.metadata(opt1=val1)(opt2=val2) #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val2) In other words, setting opt2 = val2 does not reset opt1 back to its default value.
korydraughn
reviewed
Apr 29, 2025
Comment on lines
+815
to
+817
| m4 = m3(admin = False) | ||
| self.assertEqual(m4._manager._use_ts, True) | ||
| self.assertEqual(m4._manager.get_api_keywords().get(kw.ADMIN_KW), None) |
There was a problem hiding this comment.
I take it the following assertion is left out intentionally?
self.assertEqual(m4._manager._admin, False)Does L817 cover it somehow? Seems like the ADMIN_KW is None because of m3(admin = False). Is that true? Are they related?
There was a problem hiding this comment.
I can put that in. Not sure why it got left out.
d-w-moore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words, setting opt2 = val2 does not reset opt1 back to its default value.