Update meteor.js to fix "iron run" command bug on windows #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Closed
ghost
changed the title
| @@ -163,11 +163,12 @@ module.exports.invokeMeteorCommand = function invokeMeteorCommand(cmd, args) { | |||
|
|
|||
| var future = new Future; | |||
|
|
|||
| var child = spawn('meteor', [cmd].concat(args), { | |||
| var child = spawn(process.platform === "win32" ? 'meteor.bat' : 'meteor', [cmd].concat(args), { | |||
There was a problem hiding this comment.
is meteor.bat the windows executable?
There was a problem hiding this comment.
yeah! @chrisbutler the exec file is "meteor.bat". and you can find it in here. ^_^
https://github.com/anticoders/gagarin/pull/127/files
There was a problem hiding this comment.
@spyhole i think it's actually this one? https://github.com/meteor/meteor/blob/832e6fe44f3635cae060415d6150c0105f2bf0f6/meteor.bat but nice work!
|
works great now! Thank You for this! |
chrisbutler
pushed a commit
that referenced
this pull request
Sep 1, 2015
Update meteor.js to fix "iron run" command bug on windows
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fixed "Run error on Windows" #138