Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kustomization for Cluster-API case #23

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add kustomization for Cluster-API case #23

merged 1 commit into from
Sep 4, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Sep 4, 2024

Proposed Changes

  • configure hostNetwork for CCM deployment because in CAPI case it runs on the workload cluster and taint from node will not be removed if CCM cannot reach DNS (coredns pods are still Pending )

@defo89
Add kustomization for Cluster-API case
d35df32 
configure hostNetwork for CCM deployment
@defo89 defo89 requested a review from a team as a code owner September 4, 2024 14:17
@github-actions github-actions bot added size/S enhancement New feature or request labels Sep 4, 2024
@defo89 defo89 merged commit 786a7d5 into main Sep 4, 2024
8 checks passed
@defo89 defo89 deleted the enh/capi-kustomize-hostnetwork branch September 4, 2024 14:35
afritzler
afritzler requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the hostNetwork: true to the default manager deployment as this will be true for 90% of the usecases? You can still override it yourself if needed via a kustomization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler requested changes

@hardikdr hardikdr hardikdr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@defo89 @afritzler @hardikdr