Skip to content

Commit

Permalink
incorporating review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ushabelgur committed Nov 21, 2024
1 parent 2fc54e8 commit c7fbc7e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
20 changes: 10 additions & 10 deletions api/storage/v1alpha1/volume_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@ type VolumeAccess struct {
VolumeAttributes map[string]string `json:"volumeAttributes,omitempty"`
}

// ReclaimPolicy for a Volume tells what to do with the volume after its managing resource has been deleted
type ReclaimPolicy string

const (
// The Volume resource is not deleted after the managing resource has been deleted
Retain ReclaimPolicy = "Retain"
// The Volume resource is garbage-collected when the managing resource has been deleted
Delete ReclaimPolicy = "Delete"
)

// VolumeStatus defines the observed state of Volume
type VolumeStatus struct {
// State represents the infrastructure state of a Volume.
Expand Down Expand Up @@ -123,16 +133,6 @@ type VolumeList struct {
Items []Volume `json:"items"`
}

// ReclaimPolicy for a Volume tells what to do with the volume after its managing resource has been deleted
type ReclaimPolicy string

const (
// The Volume resource is not deleted after the managing resource has been deleted
Retain ReclaimPolicy = "Retain"
// The Volume resource is garbage-collected when the managing resource has been deleted
Delete ReclaimPolicy = "Delete"
)

type EphemeralVolumeSpec struct {
VolumeSpec `json:",inline"`
// ReclaimPolicy defines the strategy for the corresponding volume resource after its managing resource has been deleted
Expand Down
20 changes: 10 additions & 10 deletions internal/apis/storage/volume_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ type VolumeAccess struct {
VolumeAttributes map[string]string
}

// ReclaimPolicy for a Volume tells what to do with the volume after its managing resource has been deleted
type ReclaimPolicy string

const (
// The Volume resource is not deleted after the managing resource has been deleted
Retain ReclaimPolicy = "Retain"
// The Volume resource is garbage-collected when the managing resource has been deleted
Delete ReclaimPolicy = "Delete"
)

// VolumeStatus defines the observed state of Volume
type VolumeStatus struct {
// State represents the infrastructure state of a Volume.
Expand Down Expand Up @@ -122,16 +132,6 @@ type VolumeList struct {
Items []Volume
}

// ReclaimPolicy for a Volume tells what to do with the volume after its managing resource has been deleted
type ReclaimPolicy string

const (
// The Volume resource is not deleted after the managing resource has been deleted
Retain ReclaimPolicy = "Retain"
// The Volume resource is garbage-collected when the managing resource has been deleted
Delete ReclaimPolicy = "Delete"
)

type EphemeralVolumeSpec struct {
VolumeSpec
// ReclaimPolicy defines the strategy for the corresponding volume resource after its managing resource has been deleted
Expand Down

0 comments on commit c7fbc7e

Please sign in to comment.