-
Notifications
You must be signed in to change notification settings - Fork 10
Closed
Closed
Copy link
Labels
area/iaasIssues related to IronCore IaaS development.Issues related to IronCore IaaS development.enhancementNew feature or requestNew feature or request
Description
Summary
As in this discussion ( #1335 (comment) ) pointed out, relying on the downward-api.machinepoollet.ironcore.dev is not optimal.
The downward-api is only intended for ops purposes and can be configured to have a different name or it might be possible that the labels are not present at all (see: machine-downward-api-label).
Proposed change
At the moment we only store the parent Machine.UID in metadata.annotations.machinebroker.ironcore.dev/labels. We can additionally put the machinepoollet.ironcore.dev/machine-uid as a label to the Machine and utilize this for filtering.
Tasks
- Validate if this changes can work
Poollet:
- Update
listMachinesByMachineKeyto use again amachineUIDLabelSelector
Broker:
- Simplify
ListMachines- Remove this check
labelFilter := req.Filter; labelFilter != nil && labelFilter.LabelSelector != niland handle it unified
- Remove this check
- Update
CreateMachineto set the label to theMachine
afritzlerbalpert89
Metadata
Metadata
Assignees
Labels
area/iaasIssues related to IronCore IaaS development.Issues related to IronCore IaaS development.enhancementNew feature or requestNew feature or request
Type
Projects
Status
Done