Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalized OwnerCache into own package and added basic test suite #101

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Externalized OwnerCache into own package and added basic test suite #101

merged 1 commit into from
Aug 11, 2021

Conversation

afritzler
Copy link
Member

Proposed Changes

  • Moved OwnerCache into a separate ownercache package
  • Moved ReconciliationTrigger into trigger package as it caused a cyclic dependency
  • Added basic test suite setup

Fixes #100

@afritzler afritzler added the enhancement New feature or request label Aug 10, 2021
@afritzler afritzler changed the title Externalized owner cache into own package and added basic test suite Externalized OwnerCache into own package and added basic test suite Aug 10, 2021
@afritzler afritzler requested a review from mandelsoft August 10, 2021 19:55
@afritzler afritzler merged commit 486c256 into main Aug 11, 2021
@afritzler afritzler deleted the enh/ext_ownercache branch August 11, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft Awaiting requested review from mandelsoft

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Externalize owner cache into own package
1 participant
@afritzler