Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Machine Runtime Interface to Support Cross-Cluster Events #1081

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Extend Machine Runtime Interface to Support Cross-Cluster Events #1081

merged 8 commits into from
Jul 11, 2024

Conversation

ushabelgur
Copy link
Contributor

@ushabelgur ushabelgur commented Jun 27, 2024 •
edited
Loading

Proposed Changes

  • Extend machine runtime interface to support ListEvents method
  • Implement ListEvents method in machine-broker
  • Implement runnable in machinepoollet to periodically synch events

Fixes #1070 (partially)

@github-actions github-actions bot added size/XXL enhancement New feature or request labels Jun 27, 2024
@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch 3 times, most recently from b7f10b5 to b2ad37d Compare July 4, 2024 07:00
@ushabelgur ushabelgur marked this pull request as ready for review July 4, 2024 07:14
@ushabelgur ushabelgur requested a review from a team as a code owner July 4, 2024 07:14
@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch from b2ad37d to 317faeb Compare July 4, 2024 07:42
afritzler
afritzler approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ushabelgur for this PR. Looks good from my side.

@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch from 317faeb to 47e7825 Compare July 8, 2024 07:24
lukasfrank
lukasfrank requested changes Jul 8, 2024
View reviewed changes
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
iri/apis/machine/v1alpha1/api.proto Outdated Show resolved Hide resolved
lukasfrank
lukasfrank reviewed Jul 8, 2024
View reviewed changes
iri/testing/machine/fake.go Show resolved Hide resolved
poollet/machinepoollet/mem/generic_test.go Outdated Show resolved Hide resolved
poollet/machinepoollet/mem/mem.go Outdated Show resolved Hide resolved
poollet/machinepoollet/mem/generic.go Outdated Show resolved Hide resolved
@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch from 9e81395 to 97d9111 Compare July 9, 2024 08:26
@ushabelgur ushabelgur requested a review from lukasfrank July 9, 2024 09:32
@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch from 97d9111 to bb44927 Compare July 10, 2024 06:17
lukasfrank
lukasfrank requested changes Jul 10, 2024
View reviewed changes
poollet/machinepoollet/mem/mem.go Outdated Show resolved Hide resolved
poollet/machinepoollet/mem/generic.go Outdated Show resolved Hide resolved
@ushabelgur ushabelgur force-pushed the enh/iri_cluster_events branch from e747028 to 28b2217 Compare July 10, 2024 09:50
lukasfrank
lukasfrank reviewed Jul 10, 2024
View reviewed changes
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
broker/machinebroker/server/event_list.go Outdated Show resolved Hide resolved
iri/testing/machine/fake.go Outdated Show resolved Hide resolved
poollet/machinepoollet/mem/mem.go Outdated Show resolved Hide resolved
lukasfrank
lukasfrank approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@lukasfrank lukasfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the PR!

@lukasfrank lukasfrank merged commit dec711a into main Jul 11, 2024
9 checks passed
@lukasfrank lukasfrank deleted the enh/iri_cluster_events branch July 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@lukasfrank lukasfrank lukasfrank approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Runtime Interface to Support Cross-Cluster Events
3 participants
@ushabelgur @afritzler @lukasfrank