Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dissallow volume updates #243

Merged
merged 6 commits into from
Dec 14, 2021
Merged

Dissallow volume updates #243

merged 6 commits into from
Dec 14, 2021

Conversation

nikhilbarge
Copy link
Contributor

Proposed Changes

Fixes #

@nikhilbarge nikhilbarge changed the title WIP: volume webhooks Dissallow volume updates Dec 12, 2021
adracus
adracus reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required

main.go Outdated Show resolved Hide resolved
apis/storage/v1alpha1/webhook_suite_test.go Outdated Show resolved Hide resolved
apis/storage/v1alpha1/volume_webhook.go Show resolved Hide resolved
@adracus adracus merged commit 4698cb8 into main Dec 14, 2021
@adracus adracus deleted the 238_dissallow_volume_updates branch December 14, 2021 11:26
@adracus adracus mentioned this pull request Dec 16, 2021
Closed
@afritzler afritzler added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adracus adracus adracus left review comments

Assignees
No one assigned
Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilbarge @adracus @afritzler