Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make webhook configs coherent #261

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Make webhook configs coherent #261

merged 1 commit into from
Jan 4, 2022

Conversation

LimKianAn
Copy link
Contributor

@LimKianAn LimKianAn commented Jan 3, 2022 •
edited
Loading

Proposed Changes

  • Use only admission.k8s.io/v1 since v1beta1 is deprecated.
  • Use meaningful domain name for webhook names.

@github-actions github-actions bot added the size/S label Jan 3, 2022
@LimKianAn LimKianAn self-assigned this Jan 3, 2022
@LimKianAn LimKianAn requested a review from afritzler January 3, 2022 17:00
afritzler
afritzler requested changes Jan 3, 2022
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the v or m prefix on the resource name correct?

apis/network/v1alpha1/ipamrange_webhook.go Show resolved Hide resolved
@afritzler afritzler merged commit b68c761 into main Jan 4, 2022
@afritzler afritzler deleted the coherent-webhook-config branch January 4, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@LimKianAn LimKianAn

Labels
chore size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LimKianAn @afritzler