Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VolumeClaim ref from Volume when the VolumeClaim can not be found #318

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Remove VolumeClaim ref from Volume when the VolumeClaim can not be found #318

merged 2 commits into from
Feb 24, 2022

Conversation

nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented Feb 24, 2022 •
edited by afritzler
Loading

Proposed Changes

  • on removal of volumeclaim claim reference should be removed from related volume.

@nikhilbarge nikhilbarge requested a review from adracus February 24, 2022 12:39
adracus
adracus reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the change.

@afritzler afritzler changed the title remove claim ref from volume Remove VolumeClaim ref from Volume when the VolumeClaim can not be found Feb 24, 2022
@afritzler
Copy link
Member

@nikhilbarge thanks for the RP - looks good! Like @adracus said, a test case would be great.

@afritzler afritzler added ok-to-🐳 bug Something isn't working labels Feb 24, 2022
@adracus adracus merged commit 73f001a into main Feb 24, 2022
@adracus adracus deleted the update_volume_claim branch February 24, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ok-to-🐳 size/XS storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilbarge @afritzler @adracus