Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ORI, broker and poollet for Buckets #623

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Implement ORI, broker and poollet for Buckets #623

merged 6 commits into from
Feb 7, 2023

Conversation

lukasfrank
Copy link
Member

@lukasfrank lukasfrank commented Jan 26, 2023 •
edited
Loading

Proposed Changes

  • Implementation for Bucket poollet, Bucket broker and orictl

@lukasfrank lukasfrank marked this pull request as ready for review January 31, 2023 10:32
@lukasfrank lukasfrank requested a review from a team as a code owner January 31, 2023 10:32
adracus
adracus approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the leader election id before merging, otherwise LGTM!

poollet/bucketpoollet/cmd/bucketpoollet/app/app.go Outdated Show resolved Hide resolved
@lukasfrank lukasfrank merged commit ff3a658 into main Feb 7, 2023
@lukasfrank lukasfrank deleted the feat/buckets branch February 8, 2023 15:15
@afritzler afritzler added the enhancement New feature or request label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasfrank @adracus @afritzler