Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption support for VolumePoollet & VolumeBroker #692

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Encryption support for VolumePoollet & VolumeBroker #692

merged 4 commits into from
Mar 30, 2023

Conversation

lukasfrank
Copy link
Member

@lukasfrank lukasfrank commented Mar 28, 2023 •
edited
Loading

Proposed Changes

@github-actions github-actions bot added size/XL enhancement New feature or request labels Mar 28, 2023
@lukasfrank lukasfrank force-pushed the enh/volume_encryption branch 2 times, most recently from eea0618 to fae48a1 Compare March 28, 2023 12:33
@lukasfrank lukasfrank marked this pull request as ready for review March 28, 2023 12:40
@lukasfrank lukasfrank requested a review from a team as a code owner March 28, 2023 12:40
@github-actions github-actions bot added size/XXL and removed size/XL labels Mar 29, 2023
@lukasfrank lukasfrank requested a review from adracus March 29, 2023 12:45
@lukasfrank lukasfrank force-pushed the enh/volume_encryption branch from e958627 to 720e4c9 Compare March 29, 2023 12:49
adracus
adracus suggested changes Mar 29, 2023
View reviewed changes
broker/volumebroker/server/volume_delete.go Outdated Show resolved Hide resolved
broker/volumebroker/server/volume_list.go Outdated Show resolved Hide resolved
broker/volumebroker/server/volume_list.go Outdated Show resolved Hide resolved
ori/testing/volume/client.go Outdated Show resolved Hide resolved
ori/testing/volume/fake.go Outdated Show resolved Hide resolved
@lukasfrank lukasfrank force-pushed the enh/volume_encryption branch from 720e4c9 to 691cb96 Compare March 29, 2023 15:08
@lukasfrank lukasfrank requested a review from adracus March 29, 2023 15:39
adracus
adracus approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving already, please merge once the rename is done.

@lukasfrank lukasfrank force-pushed the enh/volume_encryption branch from 691cb96 to 0fdd260 Compare March 29, 2023 15:46
@lukasfrank lukasfrank force-pushed the enh/volume_encryption branch from 0fdd260 to 2043438 Compare March 30, 2023 07:20
@lukasfrank lukasfrank merged commit 1a5ebcb into main Mar 30, 2023
@lukasfrank lukasfrank deleted the enh/volume_encryption branch March 30, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasfrank @adracus