Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong CSI driver name reference #275

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Fix wrong CSI driver name reference #275

merged 5 commits into from
Nov 29, 2023

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Fix wrong CSI driver name reference

Fixes #273

@ushabelgur ushabelgur requested a review from a team as a code owner November 28, 2023 16:36
@github-actions github-actions bot added size/XS bug Something isn't working provider labels Nov 28, 2023
@ushabelgur ushabelgur requested a review from afritzler November 28, 2023 16:39
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 29, 2023
@afritzler
Copy link
Member

We should add a flag to override the default value csi.ironcore.dev to ensure backward compatibility.

@github-actions github-actions bot added size/S and removed size/XS labels Nov 29, 2023
afritzler
afritzler requested changes Nov 29, 2023
View reviewed changes
pkg/ironcore/get_volume_ids.go Outdated Show resolved Hide resolved
pkg/ironcore/get_volume_ids.go Outdated Show resolved Hide resolved
@ushabelgur ushabelgur requested a review from afritzler November 29, 2023 14:03
afritzler
afritzler requested changes Nov 29, 2023
View reviewed changes
cmd/machine-controller/main.go Outdated Show resolved Hide resolved
pkg/ironcore/get_volume_ids_test.go Outdated Show resolved Hide resolved
pkg/ironcore/driver.go Outdated Show resolved Hide resolved
cmd/machine-controller/main.go Outdated Show resolved Hide resolved
@ushabelgur ushabelgur requested a review from afritzler November 29, 2023 15:01
@afritzler afritzler merged commit 45572dc into main Nov 29, 2023
@afritzler afritzler deleted the correct_csi_driver_name branch November 29, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation provider size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wrong CSI driver name reference
2 participants
@ushabelgur @afritzler