web/rest: added PUT /billable_calls/{callid}/rate endpoint #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmadariaga
changed the title
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
4 times, most recently
from
90305ca to
e927241
Compare
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
e927241 to
a59f5a7
Compare
Kaian
reviewed
Oct 23, 2019
Comment on lines
+75
to
+96
| if (count($calls) !== 1) { | ||
| $errorMsg = sprintf( | ||
| 'Multiple calls found with callid %s', | ||
| $callid | ||
| ); | ||
|
|
||
| throw new \DomainException($errorMsg, 500); | ||
| } |
There was a problem hiding this comment.
If we leave this as is, it would be impossible to tarificate bounced calls within the same brand.
Maybe we should add extra conditions to avoid this scenario (direction with outgoing as default value?)
There was a problem hiding this comment.
Updated repository query, thanks :)
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
4 times, most recently
from
a87949e to
c3b3588
Compare
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
c3b3588 to
957eb6f
Compare
Kaian
approved these changes
Oct 28, 2019
|
Rebase completed. |
ironArt3mis
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
957eb6f to
40a670a
Compare
|
Rebase completed. |
ironArt3mis
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
40a670a to
c8794bf
Compare
cruzccl
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
c8794bf to
8dba768
Compare
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
5 times, most recently
from
25fd202 to
3ffd5d0
Compare
mmadariaga
force-pushed
the
api-billable-call-endpoints-for-externally-raters
branch
from
3ffd5d0 to
99519ba
Compare
mmadariaga
deleted the
api-billable-call-endpoints-for-externally-raters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PUT /billable_calls/{callid}/rate endpoint on platoform and brand API
Type Of Change
Checklist: