derive: fix compilation error if user define its own Result type #20
Conversation
dxr_derive/src/lib.rs
Outdated
| @@ -145,7 +145,7 @@ pub fn try_from_value(input: TokenStream) -> TokenStream { | |||
|
|
|||
| let impl_block = quote! { | |||
| impl #impl_generics #dxr::TryFromValue for #name #ty_generics #where_clause { | |||
| fn try_from_value(value: &#dxr::Value) -> Result<#name #ty_generics, #dxr::DxrError> { | |||
| fn try_from_value(value: &#dxr::Value) -> std::result::Result<#name #ty_generics, #dxr::DxrError> { | |||
There was a problem hiding this comment.
Can you replace this with ::std::result::Result, similar to other std imports?
dxr_derive/src/lib.rs
Outdated
| @@ -258,7 +258,7 @@ pub fn try_to_value(input: TokenStream) -> TokenStream { | |||
|
|
|||
| let impl_block = quote! { | |||
| impl #impl_generics #dxr::TryToValue for #name #ty_generics #where_clause { | |||
| fn try_to_value(&self) -> Result<#dxr::Value, #dxr::DxrError> { | |||
| fn try_to_value(&self) -> std::result::Result<#dxr::Value, #dxr::DxrError> { | |||
abernardeau-wallix
force-pushed
the
fix-custom-result-type
branch
from
48714b2 to
c4d2738
Compare
|
Great, thanks! Let's see what the CI says. |
|
I updated the PR with your wise remarks.
This is a terrifying thought 😱. |
|
It seems that the nightly jobs is failing to the |
|
Yeah, the failure with |
abernardeau-wallix
force-pushed
the
fix-custom-result-type
branch
from
c4d2738 to
ff9a453
Compare
|
Awesome. Thank you for the contribution! |
|
Do you need a new release in the v0.6 branch with this fix? Or would it be OK if this just ends up in 0.7.0? |
|
If it's not too much work I would be happy to have a release with the fix but I can implement a workaround in my code and can wait for the 0.7.0 version. |
|
I'm working on some refactors for 0.7.0 still, so I'll cherry-pick your change onto the v0.6 release series and publish a new version. |
When using the
TryFromValueandTryToValuemacros in a file where a customResultis defined (in my casetype Result<T> = std::result::Result<T, Box<dyn Error + Send + Sync>>;) the macro doesn't work anymore and create a compilation error.The Result seems to be common pattern and I think it should not break the macrso (https://doc.rust-lang.org/rust-by-example/error/result/result_alias.html )