upgrade quick-xml #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you - I had been planning to make a new release soon, though there are still some pending changes I need to make (notably in |
|
I pushed some fixes for new clippy warnings and formatting issues and then applied the quick-xml 0.36 -> 0.37 update directly, I hope that's alright with you for a two-line change. I still need to fix up multicall support before I can publish a new release, but I still hope that will be soon. 😞 |
|
I have decided to postpone multicall client API changes in favor of getting a new release out sooner - 0.7.0 is now published. Enjoy! |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in some bugfixes since the previous version, adjusting for a small API change on serialization.
The current crates-io version of dxr still uses quick-xml 0.30.x, which has a bug in its
expand_empty_elementsbehavior that we're hitting in ros-core-rs (which depends on dxr). It would be really cool if you could do a crates.io release which has a newer quick-xml, so we could depend on that one :)