Fix #937 - Fix incorrect log access check in setuid startup

Introduced in #666
irrdnet · Apr 25, 2024 · 2f4ca06 · 2f4ca06
1 parent 9be7430
commit 2f4ca06
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/irrd/daemon/main.py b/irrd/daemon/main.py
@@ -95,11 +95,13 @@ def main():
     if uid and gid:
         os.setegid(gid)
         os.seteuid(uid)
-        if staged_logfile_path and not os.access(staged_logfile_path, os.W_OK, effective_ids=True):
-            logging.critical(
-                f"Unable to start: logfile {staged_logfile_path} not writable by UID {uid} / GID {gid}"
-            )
-            return
+        if staged_logfile_path:
+            staged_logfile_dir = Path(staged_logfile_path).parent
+            if not os.access(staged_logfile_dir, os.W_OK, effective_ids=True):
+                logging.critical(
+                    f"Unable to start: logfile {staged_logfile_path} not writable by UID {uid} / GID {gid}"
+                )
+                return
 
     with daemon.DaemonContext(**daemon_kwargs):
         config_init(args.config_file_path)