-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up updates parser tests #412
Labels
Comments
mxsasha
added a commit
that referenced
this issue
Nov 2, 2021
mxsasha
added a commit
that referenced
this issue
Nov 2, 2021
mxsasha
added a commit
that referenced
this issue
Nov 2, 2021
mxsasha
added a commit
that referenced
this issue
Nov 4, 2021
mxsasha
added a commit
that referenced
this issue
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current tests in updates/tests/test_parser.py have one test for the change request processing and all the validators. This was not a bad idea at the time, but validators have become a lot more complex since, and the tests have become a bit of a mess. Everything to do with validator testing should be split out.
Important to keep in mind is that we keep sufficient integration test cover. Probably by still having some regular tests that cast a wide net to cover larger parts of authoritative change flow.
The text was updated successfully, but these errors were encountered: