Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support new rpki-client JSON format? #499

Closed
job opened this issue May 6, 2021 · 6 comments
Closed

Add support new rpki-client JSON format? #499

job opened this issue May 6, 2021 · 6 comments
Assignees
Labels
release blocker blocks the next release
Milestone

Comments

@job
Copy link
Member

job commented May 6, 2021

The rpki-client JSON output format is slightly changing, an example of the new format can be found here: http://console.rpki-client.org/vrps.json

  1. the asn value no longer is a string prefixed with AS, but rather just a simple integer.

2) a new expires key has been added: the value signifies when the VRP will expire in of seconds since the Epoch, UTC, given the expiration timers on current chain of CRLs & CAs applicable to a given VRP. Generally objects will be between 32 and 72 hours from their expiration, and every time rpki-client refreshes its data the expiration time is bumped forwards. Perhaps this can be used for more easy garbage collection / RPKI updating? (or just ignored if it isn't useful in irrd)

@mxsasha
Copy link
Collaborator

mxsasha commented May 28, 2021

For point 1, this is already mostly supported, the only issue is that SLURM validationOutputFilters would not be correctly matched.

For point 2, maybe, we can take this into consideration in #497. Otherwise, extra data in the JSON is ignored, so it won't break anything.

@mxsasha mxsasha self-assigned this May 28, 2021
@mxsasha mxsasha added the release blocker blocks the next release label May 28, 2021
@mxsasha mxsasha added this to the Release 4.2 milestone May 28, 2021
@job
Copy link
Member Author

job commented Jun 17, 2021

Dear @mxsasha ,

It appears point 1 has become a blocker for some ISPs to upgrade their RPKI validators.

Would it be possible to resolve point 1 with a backport to 4.1.x ?

Kind regards,

Job

@job
Copy link
Member Author

job commented Jun 17, 2021

Now both variants are supported?

@mxsasha
Copy link
Collaborator

mxsasha commented Jun 17, 2021

It should, yes. But will do a bit more testing.

@job
Copy link
Member Author

job commented Jun 18, 2021

I realize I should've made two issues, I updated the original posting :-)

@job
Copy link
Member Author

job commented Jun 18, 2021

I tested this PR applied to b16bd50

both formats (old and new) work correctly

mxsasha added a commit that referenced this issue Jun 18, 2021
mxsasha added a commit that referenced this issue Jun 18, 2021
@mxsasha mxsasha closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release blocker blocks the next release
Projects
None yet
Development

No branches or pull requests

2 participants