Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping support for Python 3.6 #604

Closed
mxsasha opened this issue Dec 27, 2021 · 5 comments · Fixed by #657
Closed

Consider dropping support for Python 3.6 #604

mxsasha opened this issue Dec 27, 2021 · 5 comments · Fixed by #657
Assignees
@mxsasha

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Dec 27, 2021 •
edited
Loading

Python 3.6 has passed end of life. It's currently blocking an upgrade to the latest ujson and setuptools dependency. That should be ok for now, but eventually the 3.6 support will start hurting more. Dropping 3.6 also allows a bit of cleanup. Some OS vendors may still be supporting 3.6 for a while though, so main question is whether there are any major IRRD deployments that are running on 3.6.
@troy2914
Copy link
Member

Ubuntu 18.04 still uses python3.6

@mxsasha
Copy link
Collaborator Author

mxsasha commented Dec 27, 2021

Ubuntu 18.04 still uses python3.6

Which I see is still supported until April 2023. So let's keep 3.6 support for now, and deal with it if it ever becomes a significant problem for IRRD.

@mxsasha mxsasha closed this as completed Dec 27, 2021
@mxsasha mxsasha self-assigned this Dec 27, 2021
mxsasha pushed a commit that referenced this issue Feb 14, 2022
@pyup-bot
Scheduled weekly dependency update for week 07 (#621)
5799fc7 
A bunch of additional dependencies are pinned lower for #604
mxsasha added a commit that referenced this issue Mar 31, 2022
@mxsasha
Remove PyUp badge as it "falsely" labels insecure
74c80b7 
Due to #604, we are stuck to a number of old dependencies. Some
of these have vulnerabilities that do not affect us, but PyUp
does not support dismissing them, causing the badge to always
show as "insecure".
@mxsasha
Copy link
Collaborator Author

mxsasha commented Mar 31, 2022

Our dependencies are removing 3.6 support fairly fast. Out of 44 direct dependencies, I have had to pin the versions of 9 already to keep 3.6 compatibility. Two of those have vulnerabilities, but so far none that affect us. If one has a vulnerability or critical bug that does affect IRRd, our only option is to vendor the package into IRRd or fork it and fix it manually, which can take considerable time and effort. This will also become an increasing issue with ongoing development too.

We can only drop Python versions in minor (4.x.0) releases, as we need to be able to patch older releases. Although I generally prefer keeping upgrades easy, I propose we drop 3.6 support starting 4.3.0, before it starts to hurt more.

@mxsasha mxsasha reopened this Mar 31, 2022
@rubenskuhl
Copy link

Would 3.8 still be in play ?

@mxsasha
Copy link
Collaborator Author

mxsasha commented Apr 1, 2022

Would 3.8 still be in play ?

Definitely. At least for another 2.5 years.

mxsasha added a commit that referenced this issue Apr 5, 2022
@mxsasha
[4.2.x] Remove PyUp badge as it "falsely" labels insecure
9302a09 
Due to #604, we are stuck to a number of old dependencies. Some
of these have vulnerabilities that do not affect us, but PyUp
does not support dismissing them, causing the badge to always
show as "insecure".

(cherry picked from commit 74c80b7)
mxsasha added a commit that referenced this issue Jun 17, 2022
@mxsasha
Fix #604 - Drop Python 3.6 support for main branch and therefore 4.3+
f4b774f
@mxsasha mxsasha linked a pull request Jun 17, 2022 that will close this issue
Fix #604 - Drop Python 3.6 support for main branch and therefore 4.3+ #657
Merged
mxsasha added a commit that referenced this issue Jun 17, 2022
@mxsasha
Fix #604 - Drop Python 3.6 support for main branch and therefore 4.3+ (…
6a10d3b 
…#657)

Also removes version restrictions from requirements.txt
mxsasha added a commit that referenced this issue Jul 1, 2022
@mxsasha
Ref #604 - Drop dataclasses from requirements, was only for 3.6
aefeec1
mxsasha added a commit that referenced this issue Jul 1, 2022
@mxsasha
Ref #604 - Drop dataclasses from requirements, was only for 3.6
9a1d61d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxsasha mxsasha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #604 - Drop Python 3.6 support for main branch and therefore 4.3+ irrdnet/irrd
3 participants
@mxsasha @rubenskuhl @troy2914