Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #575 - Add extended set validation #585

Merged
merged 11 commits into from
Dec 18, 2021
Merged

Fix #575 - Add extended set validation #585

merged 11 commits into from
Dec 18, 2021

Conversation

mxsasha
Copy link
Collaborator

@mxsasha mxsasha commented Nov 9, 2021 •
edited
Loading

docs:
https://irrd.readthedocs.io/en/extended-set-575-2/admins/configuration/#authentication-and-validation
https://irrd.readthedocs.io/en/extended-set-575-2/users/database-changes/#related-maintainers-in-set-objects

  • fix inline todo's
  • authenticate_related_mntners setting may now be confusing
  • write docs
  • decide on appropriate defaults for new auth.set_creation setting
  • Look into upgrade path: when people migrate with 4.1 settings, should we still accept those? Concerns one rename and one removed setting. Keep an eye on confusing/conflicting settings and defaults.
  • Write release notes for the upgrade path.
  • review/refactor all code/docs
  • deploy and verify working on test instance
  • cleanup test_validators.py
  • check integration test

@mxsasha mxsasha linked an issue Nov 9, 2021 that may be closed by this pull request
Extended RPSL set name validation and authentication #575
Closed
@mxsasha mxsasha force-pushed the extended-set-575-2 branch 6 times, most recently from a6a9f50 to 2f1b467 Compare November 10, 2021 14:14
@mxsasha mxsasha self-assigned this Nov 11, 2021
@mxsasha mxsasha added the enhancement New feature or request label Nov 11, 2021
@mxsasha mxsasha added this to the Release 4.3 milestone Nov 11, 2021
@mxsasha mxsasha marked this pull request as ready for review November 11, 2021 15:02
@mxsasha mxsasha force-pushed the extended-set-575-2 branch 4 times, most recently from 1bb7212 to 92a74f8 Compare November 24, 2021 12:47
mxsasha
mxsasha commented Nov 25, 2021
View reviewed changes
irrd/conf/__init__.py Outdated Show resolved Hide resolved
irrd/conf/__init__.py Outdated Show resolved Hide resolved
docs/users/database-changes.rst Outdated Show resolved Hide resolved
docs/users/database-changes.rst Outdated Show resolved Hide resolved
docs/releases/4.3.0.rst Outdated Show resolved Hide resolved
docs/releases/4.3.0.rst Outdated Show resolved Hide resolved
irrd/updates/validators.py Outdated Show resolved Hide resolved
mxsasha added a commit that referenced this pull request Dec 18, 2021
@mxsasha
broken implementation of hiding behind setting, merge #585 first
8fb661f
@mxsasha mxsasha enabled auto-merge (squash) December 18, 2021 13:10
@mxsasha mxsasha merged commit 34fba18 into main Dec 18, 2021
@mxsasha mxsasha deleted the extended-set-575-2 branch December 18, 2021 13:12
mxsasha added a commit that referenced this pull request Dec 18, 2021
@mxsasha
broken implementation of hiding behind setting, merge #585 first
ec9ecd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mxsasha mxsasha

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 4.3
Development

Successfully merging this pull request may close these issues.

Extended RPSL set name validation and authentication
1 participant
@mxsasha