fix: decodeTxs ch block

irrun · Feb 27, 2024 · 86f7079 · 86f7079
1 parent bfc662d
commit 86f7079
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/core/types/bid.go b/core/types/bid.go
@@ -84,7 +84,7 @@ func (b *RawBid) DecodeTxs(signer Signer) ([]*Transaction, error) {
  return []*Transaction{}, nil
  }
 
- txChan := make(chan int, TxDecodeConcurrencyForPerBid)
+ txChan := make(chan int, len(b.Txs))
  bidTxs := make([]*Transaction, len(b.Txs))
  decode := func(txBytes hexutil.Bytes) (*Transaction, error) {
  tx := new(Transaction)
@@ -104,7 +104,13 @@ func (b *RawBid) DecodeTxs(signer Signer) ([]*Transaction, error) {
  errChan := make(chan error, TxDecodeConcurrencyForPerBid)
  for i := 0; i < TxDecodeConcurrencyForPerBid; i++ {
  go func() {
- for txIndex := range txChan {
+ for {
+ txIndex, ok := <-txChan
+ if !ok {
+ errChan <- nil
+ return
+ }
+
  txBytes := b.Txs[txIndex]
  tx, err := decode(txBytes)
  if err != nil {
@@ -114,8 +120,6 @@ func (b *RawBid) DecodeTxs(signer Signer) ([]*Transaction, error) {
 
  bidTxs[txIndex] = tx
  }
-
- errChan <- nil
  }()
  }