Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Handle checks better inside initialization callback of assets and sensors #1025

Open
1 of 2 tasks
Mayankm96 opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2166
Open
1 of 2 tasks

[Proposal] Handle checks better inside initialization callback of assets and sensors #1025

Mayankm96 opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2166
Assignees
Labels
enhancement New feature or request

Comments

@Mayankm96
Copy link
Contributor

Mayankm96 commented Sep 23, 2024

Proposal

Right now, the initialize_impl callback in assets and sensors has many checks that raise errors. However, these are captured by the callback thread instead of the primary process. Thus, the error message happens later when they start using the instance. This has been misleading the users as the errors they see are something completely else.

I have to think of a clear way to trigger an exit on a callback check. But made this proposal as a way to start thinking of this process.

Checklist

  • I have checked that there is no similar issue in the repo (required)

Acceptance Criteria

  • Checks inside the initialize callback cause the main process to exit (instead of the callback thread)
@RandomOakForest RandomOakForest added the enhancement New feature or request label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants