603/event-survey-field-enhancement #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e have for post-resources
…ate so that it is better for creating new dates
- Refactored eventSurvey presenter in metaItems.tsx to display a single editable title and URL field using MetaItemPresenter - Removed add, remove, and reorder buttons to reflect new API model (eventSurvey is now a single ExternalReference, not an array) - Ensured fields are always visible and editable, even if eventSurvey is null - Improved type safety and consistency with other meta item presenters
…veyMetaPresenter component - Created EventSurveyMetaPresenter as a dedicated function component for editing eventSurvey fields - Ensured eventSurvey fields (title, url) are always visible and editable, with no add/remove/reorder buttons - Improved type safety and consistency with other meta item presenters - Updated metaItems.tsx to use the new presenter for eventSurvey
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request refactors the handling of the
eventSurveyfield within the event meta items to improve accessibility, readability, and maintainability. Instead of displaying the survey as a simple string or array, the new implementation introduces a dedicatedEventSurveyMetaPresentercomponent that presents the survey's Title and URL fields in a clear, editable layout consistent with other resource fields, but without any add, remove, or reorder buttons. The layout uses semantic markup for better accessibility and ensures that both fields are always visible, even if the survey data is empty or null, providing a more predictable and user-friendly editing experience. Additionally, the codebase benefits from improved type safety and maintainability by encapsulating the presenter logic in a reusable function component and updating the empty document template to match the new data structure.Ticket: #603
Media attachement(s):
Screenshot of the changes in the event survey field in a test event template on the local environment.