539/careers-section-styling-fix #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…tioned in figma feedback
KrisBoxAND
requested changes
Nov 7, 2024
| {imgSrc && <CardImg variant="top" src={imgSrc} alt={imgAlt} className="career-media-row-image" />} | ||
| <CardBody className="career-card-body d-flex flex-wrap flex-column"> | ||
| {children} | ||
| <CardTitle className="career-subtitle">{title}</CardTitle> |
There was a problem hiding this comment.
i don't agree with this change. what was it done to fix? to make it look like the news card?
If so, i'd look to change the news card - as this is using the bootstrap styling which is preferable :)
…plemented these changes for NewsCard titles
|
KrisBoxAND
approved these changes
Nov 8, 2024
Parth097
pushed a commit
that referenced
this pull request
Nov 12, 2024
Parth097
added a commit
that referenced
this pull request
Nov 12, 2024
* Content changes. Added new cs-journeys image. * Fixing tests * Changed the fonts to use only roboto, and dm sans. dm sans is for titles, and roboto for copy. * Removed focus on the arrow buttons. This will stop the size changes on click in mobile view and normal view. * Increased the size of the breadcrumb * Fixing sonar cloud issues * 539/careers-section-styling-fix (#285) * 526/aqa-teaching-order-enhancement (#286) * Fixed search icons --------- Co-authored-by: Shavana Peynado <shavypeynado@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://github.com/isaaccomputerscience/isaac-cs-issues/issues/539
Created a new PR from #283 so that the commit history aligns with main