Privacy Policy Modal #379
Open
Privacy Policy Modal #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roken test. Connected the button to an api end point to recieve the data
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mariusmarin-dev
approved these changes
Aug 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to handle updated privacy policy acceptance, modifies modal behavior, and includes related updates to types, constants, and tests. The key changes are grouped below:
Privacy Policy Update Handling:
PolicyUpdateModalcomponent to prompt users to accept the updated privacy policy. The modal is non-closeable and includes a button to record acceptance (src/app/components/elements/modals/PolicyUpdateModal.tsx).PolicyUpdateModalwhen the user has not accepted the updated privacy policy or their acceptance time is outdated (src/app/state/middleware/notificationManager.ts).updatePrivacyPolicyAcceptedTimeto record the timestamp when the user accepts the privacy policy (src/app/services/api.ts).Type and Constant Updates:
RegisteredUserDTOandUserSummaryDTOto include theprivacyPolicyAcceptedTimefield (src/IsaacApiTypesAutoGenerated.tsx). [1] [2]USER_PRIVACY_POLICY_UPDATE_*action types and corresponding actions to handle privacy policy updates (src/app/services/constants.ts,src/app/state/actions/index.tsx). [1] [2]POLICY_UPDATE_TIMEto track the last privacy policy update date (src/app/components/elements/modals/inequality/constants.ts).Modal Behavior Enhancements:
ActiveModalcomponent to respect theisCloseableproperty, preventing modals from being closed if set tofalse(src/app/components/elements/modals/ActiveModal.tsx). [1] [2]ActiveModaltype to include theisCloseableproperty (src/IsaacAppTypes.tsx).Test Adjustments:
NotificationModalto account for the removal of the close button in non-closeable modals (src/test/components/elements/modals/NotificationModal.test.tsx). [1] [2] [3] [4]These changes ensure that users are prompted to accept updated privacy policies in a seamless and enforceable manner, while also improving modal behavior and maintaining test coverage.