Tutor user role #503
Merged
Tutor user role #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 25.75% // Head: 26.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 25.75% 26.86% +1.11%
==========================================
Files 481 481
Lines 21932 21919 -13
Branches 2723 2720 -3
==========================================
+ Hits 5649 5889 +240
+ Misses 15791 15510 -281
- Partials 492 520 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Or rather, via anywhere but the dedicated "change user role" endpoint
Also prevents tutors from adding other group managers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public static final String TEST_STUDENT_EMAIL = "test-student@test.com"; | ||
| public static final String TEST_STUDENT_PASSWORD = "test1234"; | ||
| public static final long TEST_STUDENT_ID = 6L; | ||
|
|
||
| public static final String TEST_TUTOR_EMAIL = "test-tutor@test.com"; | ||
| public static final String TEST_TUTOR_PASSWORD = "test1234"; |
Check failure
Code scanning / CodeQL
Hard-coded credential in API call
Comment on lines
+65
to
+66
| PreparedStatement pst = postgresSqlDb.getDatabaseConnection().prepareStatement( | ||
| "DELETE FROM group_additional_managers WHERE group_id in (?, ?);"); |
Check warning
Code scanning / CodeQL
Potential database resource leak
mwtrew
reviewed
Dec 22, 2022
Is the attribute is false, this should be disallowed
jsharkey13
reviewed
Jan 6, 2023
src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/UserAccountManager.java
Outdated
Show resolved
Hide resolved
…nto tutor-user-role
Add checking teacher-level permissions as a specific function (as opposed to an implied construct beforehand), and disallow students from seeing other users data.
…ac-api into tutor-user-role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
TUTORrole, and changes the semantics of different endpoints to cope with this additional role type.Front end PR
Tutor welcome email can be found in the content repo(s) as:
email_templates/tutor_welcome.json(needs to be copyedited first)Pull Request Check List