-
Notifications
You must be signed in to change notification settings - Fork 7
Load gameboard question limit from config #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 36.52% 37.22% +0.69%
==========================================
Files 536 536
Lines 23702 23706 +4
Branches 2857 2857
==========================================
+ Hits 8658 8825 +167
+ Misses 14185 14003 -182
- Partials 859 878 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ment/increase-gameboard-q-limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing logIn
for the new integration tests. I interrupted my work reviewing the other PR because I realised I might need this same function for working with other tests -- this is as essential addition! CookieJar looks like a neat implementation, and I like that it can be freely attached or detached from a client. The name is very Java and explains what it does if I squint a little :).
I've left a comment where I'm concerned about application behaviour though, but maybe I just need to better understand what getSelectedGameboardQuestions
does!
No description provided.