Skip to content

Conversation

mwtrew
Copy link
Contributor

@mwtrew mwtrew commented Aug 27, 2025

No description provided.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.22%. Comparing base (40fe063) to head (7a6a9b9).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../ac/cam/cl/dtg/isaac/api/managers/GameManager.java 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   36.52%   37.22%   +0.69%     
==========================================
  Files         536      536              
  Lines       23702    23706       +4     
  Branches     2857     2857              
==========================================
+ Hits         8658     8825     +167     
+ Misses      14185    14003     -182     
- Partials      859      878      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwtrew mwtrew changed the base branch from master to main September 12, 2025 15:10
Copy link
Contributor

@barna-isaac barna-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing logIn for the new integration tests. I interrupted my work reviewing the other PR because I realised I might need this same function for working with other tests -- this is as essential addition! CookieJar looks like a neat implementation, and I like that it can be freely attached or detached from a client. The name is very Java and explains what it does if I squint a little :).

I've left a comment where I'm concerned about application behaviour though, but maybe I just need to better understand what getSelectedGameboardQuestions does!

@mwtrew mwtrew marked this pull request as ready for review September 15, 2025 12:57
@barna-isaac barna-isaac merged commit b2a6e60 into main Sep 15, 2025
5 checks passed
@barna-isaac barna-isaac deleted the improvement/increase-gameboard-q-limit branch September 15, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants