Respect nofilter in Set Tests
#719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more granular control over test visibility. Instead of relying on `hiddenFromRoles` to hide certain tests from the list of available tests (which also implies making them inaccessible via a direct link), we can hide them from that list using `nofilter` while still allowing them to be accessed via direct link.
This means we won't need to clear and restore our local DB in order to work with test data - this one will load the integration test data by default.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage ? 36.53%
=======================================
Files ? 536
Lines ? 23699
Branches ? 2857
=======================================
Hits ? 8658
Misses ? 14182
Partials ? 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsharkey13
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more granular control over test visibility. Instead of relying on
hiddenFromRoles: [ 'TEACHER' ]to hide certain tests from the list of available tests (which also implies making them inaccessible via a direct link), we can hide them from that list usingnofilterwhile still allowing them to be accessed via direct link.Not strictly related, but this PR also adds a new
it-postgrescontainer to the local compose file, which avoids this dance and makes it easier to develop integration tests. I'll update the wiki once this is merged.