Skip to content

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Sep 3, 2025

The change is very straightforward, but the timing slightly less. This will need to merge first, then a week later the react-app, and the content only once the second release has happened.

The only side effect from this is that people using the old version of the app after the second release will see no maximum marks displayed until they've answered the question, but this isn't a major issue and will be resolved by a refresh so 🤷‍♀️ I think it's fine.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.52%. Comparing base (ce07b47) to head (16b8c7a).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
.../cl/dtg/isaac/dto/IsaacLLMFreeTextQuestionDTO.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   36.51%   36.52%           
=======================================
  Files         536      536           
  Lines       23692    23702   +10     
  Branches     2856     2857    +1     
=======================================
+ Hits         8652     8658    +6     
- Misses      14181    14185    +4     
  Partials      859      859           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@axlewin axlewin merged commit b5e848a into main Sep 5, 2025
5 checks passed
@axlewin axlewin deleted the hotfix/max-marks-dto branch September 5, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants