Add pre-filtered table for state schools #724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 36.51% 37.22% +0.70%
==========================================
Files 536 536
Lines 23692 23706 +14
Branches 2856 2857 +1
==========================================
+ Hits 8652 8825 +173
+ Misses 14181 14003 -178
- Partials 859 878 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsharkey13
reviewed
Oct 2, 2025
| (SELECT user_id, timestamp from anonymous.workshop_join_events); | ||
| (SELECT user_id, timestamp from anonymous.workshop_join_events); | ||
|
|
||
| CREATE TABLE anonymous.england_scotland_state_schools_v2 AS |
There was a problem hiding this comment.
This is fine to create a new table, but it won't inherit the indices of its base table. Whilst we don't want the indices created unnecessarily during the initial initialisation of the anon database (before sending), we may want to add an index and primary key to this table elsewhere?
There was a problem hiding this comment.
Ah yes, we usually do that here - thanks for reminding me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pre-filtered table of state schools matching our definition, to avoid repetition at the Superset dataset level.