Skip to content

Conversation

axlewin
Copy link
Contributor

@axlewin axlewin commented Oct 6, 2025

IsaacFastTrackQuestionPage extends IsaacQuestionPage without defining a new constructor, so Jackson uses the default constructor which takes no arguments and doesn't know about permissions or notes. Therefore these fields need getters/setters in SeguePage.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.28%. Comparing base (e2a11e6) to head (4a975e0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../uk/ac/cam/cl/dtg/isaac/dos/content/SeguePage.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   37.29%   37.28%   -0.01%     
==========================================
  Files         536      536              
  Lines       23726    23732       +6     
  Branches     2861     2861              
==========================================
  Hits         8849     8849              
- Misses      13995    14001       +6     
  Partials      882      882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sjd210 sjd210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@sjd210 sjd210 merged commit bde34c2 into main Oct 6, 2025
5 checks passed
@sjd210 sjd210 deleted the hotfix/notes-perms branch October 6, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants