Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert invalid group greying in Set Quiz modal #1118

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Sep 11, 2024

A change here added a front-end warning and disabling of invalid groups (for which the quiz had already been set) in the dropdown menu.

This reverts the disabling in the dropdown menu (since it was unclear what was happening) but keeps the front-end warning.

(I also noticed that the check for passing due date was checking for the past instead of the future so that's been fixed here too)

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.48%. Comparing base (1419464) to head (fbbb9b8).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...pp/components/elements/modals/QuizSettingModal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1118      +/-   ##
==========================================
+ Coverage   36.43%   36.48%   +0.05%     
==========================================
  Files         427      427              
  Lines       19066    19039      -27     
  Branches     6281     5632     -649     
==========================================
  Hits         6947     6947              
- Misses      11488    12054     +566     
+ Partials      631       38     -593     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsharkey13 jsharkey13 merged commit d65b92b into master Sep 11, 2024
4 checks passed
@jsharkey13 jsharkey13 deleted the hotfix/reassign-quiz-recover-warning branch September 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants