Skip to content

Conversation

@sjd210
Copy link
Contributor

@sjd210 sjd210 commented Sep 23, 2025

This touches several different areas, and makes some minor improvements to Ada along the way. In brief:

  • Overhauls LLM-marked question page to actually have styling on Sci
    • I'm not entirely confident on the layout and colouring, but I mostly just want it an a state that the Sci team can use and give feedback on
    • A question page with multiple question parts in an accordion in which only some are LLM-marked have those specific accordions labelled (This also affects Ada, but only for question pages with multiple parts e.g. intern-written extend pages)
  • Adds LLM-marked indicator to the Question Finder ALVI. Happy for feedback on the placement - maybe we make it a little smaller?
  • When the account settings are linked to in reference to consent, highlight the relevant setting (This affects Ada too).
  • Links exist to the privacy policy, although the page itself has yet to be changed. I've removed FAQ links from text, but we probably should have some information there too and re-link it.

(I've changed my local dev Sops config, porting over the ada staging configs, to make the questions actually answerable. It'll probably help to do the same when reviewing)

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 36.61972% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.33%. Comparing base (6104aea) to head (14143a0).
⚠️ Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
src/test/pages/LLMFreeTextQuestion.cy.tsx 0.00% 9 Missing ⚠️
...nents/navigation/LLMFreeTextQuestionInfoBanner.tsx 25.00% 6 Missing ⚠️
src/mocks/handlers.ts 0.00% 6 Missing ⚠️
src/app/components/content/IsaacQuestion.tsx 0.00% 5 Missing ⚠️
src/app/components/elements/Accordion.tsx 16.66% 5 Missing ⚠️
...nents/elements/LLMFreeTextQuestionFeedbackView.tsx 40.00% 3 Missing ⚠️
...mponents/elements/LLMFreeTextQuestionIndicator.tsx 50.00% 2 Missing ⚠️
...ments/LLMFreeTextQuestionRemainingAttemptsView.tsx 0.00% 2 Missing ⚠️
src/app/components/elements/PageMetadata.tsx 71.42% 2 Missing ⚠️
...ents/elements/list-groups/AbstractListViewItem.tsx 33.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   41.37%   41.33%   -0.04%     
==========================================
  Files         533      534       +1     
  Lines       23440    23482      +42     
  Branches     6920     6933      +13     
==========================================
+ Hits         9698     9707       +9     
- Misses      13701    13734      +33     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjd210 sjd210 marked this pull request as ready for review October 3, 2025 10:27
@jacbn
Copy link
Contributor

jacbn commented Oct 8, 2025

This works great! The separation of colours into Isaac- and Ada- specific .scss files is a little annoying, and perhaps encourages some thought into shared colours. I tried this to some extent with $color-theme-xxx but the shades of grey in particular are now quite disjointed (there are 3? 4? types of grey) and it is annoying.

This point aside for now, I have suggested a few styling changes here: #1767. Most of it is cleaning up, but I wanted to make sure we were using the new styling where relevant. I also shrunk the .small version a bit more, and I think it fits more cleanly in search results. Let me know what you think!

sjd210 and others added 3 commits October 10, 2025 09:44
…marked-interface

[VRT] Update baselines for improvement/isaac-llm-marked-interface
@sjd210
Copy link
Contributor Author

sjd210 commented Oct 10, 2025

Cleanup very much appreciated! Especially around some of the older code that I didn't bother to touch. There were a couple of small things to fix from that, such as setting the table background to white when in an accordion (reactstrap had been setting it to transparent, which looked odd).

Additionally, I've set the beta setting to staff-only for now and added a set of VRTs to test the questions. I decided to put it into its own VRT rather than the existing question page one because a) it has several unique components that'll be easier to check in isolation and b) it required some mocking and extra interaction to have the markscheme show up so it feels clearer to have it separate.

Copy link
Contributor

@jacbn jacbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Agree that the LLM ought to be in its own cypress test :)

@jacbn jacbn merged commit 900b675 into main Oct 10, 2025
10 checks passed
@jacbn jacbn deleted the improvement/isaac-llm-marked-interface branch October 10, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants