-
Notifications
You must be signed in to change notification settings - Fork 6
Make LLM-marked questions presentable on Isaac Science #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following the pattern for notifications, but requiring padding to be moved external to the component to work on Sci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
- Coverage 41.37% 41.33% -0.04%
==========================================
Files 533 534 +1
Lines 23440 23482 +42
Branches 6920 6933 +13
==========================================
+ Hits 9698 9707 +9
- Misses 13701 13734 +33
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…marked-interface [VRT] Update baselines for improvement/isaac-llm-marked-interface
|
This works great! The separation of colours into Isaac- and Ada- specific .scss files is a little annoying, and perhaps encourages some thought into shared colours. I tried this to some extent with $color-theme-xxx but the shades of grey in particular are now quite disjointed (there are 3? 4? types of grey) and it is annoying. This point aside for now, I have suggested a few styling changes here: #1767. Most of it is cleaning up, but I wanted to make sure we were using the new styling where relevant. I also shrunk the |
This reverts commit c1ed47b.
…justments LLM styling suggestions
…marked-interface [VRT] Update baselines for improvement/isaac-llm-marked-interface
…marked-interface [VRT] Update baselines for improvement/isaac-llm-marked-interface
…marked-interface [VRT] Update baselines for improvement/isaac-llm-marked-interface
|
Cleanup very much appreciated! Especially around some of the older code that I didn't bother to touch. There were a couple of small things to fix from that, such as setting the table background to white when in an accordion (reactstrap had been setting it to transparent, which looked odd). Additionally, I've set the beta setting to staff-only for now and added a set of VRTs to test the questions. I decided to put it into its own VRT rather than the existing question page one because a) it has several unique components that'll be easier to check in isolation and b) it required some mocking and extra interaction to have the markscheme show up so it feels clearer to have it separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Agree that the LLM ought to be in its own cypress test :)
This touches several different areas, and makes some minor improvements to Ada along the way. In brief:
(I've changed my local dev Sops config, porting over the ada staging configs, to make the questions actually answerable. It'll probably help to do the same when reviewing)