Skip to content

Adjust app to allow for reduced data in LLM-marked validation #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
+4 −7
Merged

Adjust app to allow for reduced data in LLM-marked validation #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f609b06
Remove now unused fields from validationDTO
sjd210 Oct 3, 2025
b7f5b60
Use maxMarks from doc rather than response
sjd210 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/IsaacApiTypes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,6 @@ export interface InlineRegionValidationResponseDTO extends QuestionValidationRes
}

export interface LLMFreeTextQuestionValidationResponseDTO extends QuestionValidationResponseDTO {
markCalculationInstructions?: string;
additionalMarkingInstructions?: string;
maxMarks?: number;
marksAwarded?: number;
markBreakdown?: LLMFreeTextMarkSchemeEntryDTO[];
}
Expand Down
3 changes: 1 addition & 2 deletions src/app/components/content/IsaacQuestion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio
const [hasSubmitted, setHasSubmitted] = useState<boolean>(false);
const hidingAttempts = useAppSelector(selectors.user.preferences)?.DISPLAY_SETTING?.HIDE_QUESTION_ATTEMPTS ?? false;


const {confidenceState, setConfidenceState, validationPending, setValidationPending, confidenceDisabled, recordConfidence, showQuestionFeedback} = useConfidenceQuestionsValues(
currentGameboard?.tags?.includes("CONFIDENCE_RESEARCH_BOARD"),
"question",
Expand Down Expand Up @@ -289,7 +288,7 @@ export const IsaacQuestion = withRouter(({doc, location}: {doc: ApiTypes.Questio

{/* LLM free-text question validation response */}
{isLLMFreeTextQuestion && showQuestionFeedback && validationResponse && showInlineAttemptStatus && !canSubmit &&
<LLMFreeTextQuestionFeedbackView {...{validationResponse, hasSubmitted, sentFeedback, setSentFeedback}} />
<LLMFreeTextQuestionFeedbackView maxMarks={(doc as ApiTypes.IsaacLLMFreeTextQuestionDTO).maxMarks ?? 0} {...{validationResponse, hasSubmitted, sentFeedback, setSentFeedback}} />
}
</ConfidenceContext.Provider>;
});
5 changes: 3 additions & 2 deletions src/app/components/elements/LLMFreeTextQuestionFeedbackView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ const noFeedback = {disagree: false, partlyAgree: false, agree: false};

interface LLMFreeTextQuestionFeedbackViewProps {
validationResponse: Immutable<LLMFreeTextQuestionValidationResponseDTO>;
maxMarks: number;
hasSubmitted: boolean;
sentFeedback: boolean;
setSentFeedback: (value: boolean) => void;
}
export default function LLMFreeTextQuestionFeedbackView({validationResponse, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) {
export default function LLMFreeTextQuestionFeedbackView({validationResponse, maxMarks, hasSubmitted, sentFeedback, setSentFeedback}: LLMFreeTextQuestionFeedbackViewProps) {
const dispatch = useAppDispatch();
const page = useAppSelector(selectors.doc.get);
const pageId = page && page !== NOT_FOUND && page.id || undefined;
Expand All @@ -35,7 +36,7 @@ export default function LLMFreeTextQuestionFeedbackView({validationResponse, has
<div className="prediction my-4">
<div className='d-flex'>
<span className="icon-ai me-2"/>
<strong>{`Prediction: ${validationResponse.marksAwarded} out of ${validationResponse.maxMarks} marks`}</strong>
<strong>{`Prediction: ${validationResponse.marksAwarded} out of ${maxMarks} marks`}</strong>
</div>
</div>
<div className="table-responsive card curved-table-wrapper mb-4">
Expand Down