-
Notifications
You must be signed in to change notification settings - Fork 131
Disable pull requests while keeping issues for a repository #1191
Comments
This is pretty much the standard meaningless reply from GitHub which I've seen with every feature request I've proposed - the request vanishes into their black box system and we have no clue when or even if it will ever be implemented. For now it seems that a workaround is required. Here are a few options:
Of course you could combine the template approach with the auto-closer approach. |
This repository was created for a specific purpose, which was fulfilled back in 2016. However people are still submitting issues about GitHub to the repository's issue tracker. This effectively fragments and weakens the GitHub community, because https://github.com/isaacs/github was already established in 2013 for the same purpose, and has acquired very significant momentum since then. It is more efficient for the community to pool its efforts in a single place, so make an issue template which explains the current situation and encourages people to submit issues to isaacs instead of here. This partially addresses dear-github#207. When combined with a PR auto-closer bot as suggested in isaacs/github#1191 the combination could be considered as a full solution for dear-github#207.
I've made a new app that immediately closes and locks new and existing issues or pull requests and also supports posting a comment and labeling. It is perfect for forks and mirrors, and you can configure it to your liking. Let me know how it works for you! |
- ref: 'repo-lockdown' Probot at <https://github.com/dessant/repo-lockdown> (fork:https://github.com/CICD-tools/repo-lockdown) - ref: [GH Feature Request to Disable PRs](dear-github/dear-github#84) - ref: [Discussion](isaacs/github#1191)
- ref: 'repo-lockdown' Probot at <https://github.com/dessant/repo-lockdown> (fork:https://github.com/CICD-tools/repo-lockdown) - ref: [GH Feature Request to Disable PRs](dear-github/dear-github#84) - ref: [Discussion](isaacs/github#1191)
See the recent discussion on Hacker News that mentions this issue: https://news.ycombinator.com/item?id=25940195 |
One problem I see with this, is that it would prevent people to see/use patches other people made available through pull requests. It happened to me in the past: a given bug fix or feature wasn't in master because the project was abandoned, but was available in a PR by someone that took the time to fix it. In these cases it's useful to have this code available so you can use in your own fork or patch locally. I think it'd be better to just lock the ability of external contributors to open new pull requests, without making the existing ones unavailable, nor preventing official contributors to open new ones.. |
I think that case is still handled if issues are open, and the person posts a link to their fork that fixes the issue. |
This comment has been minimized.
This comment has been minimized.
Their roadmap repo does actually seem to have PRs restricted to collaborators. I went to a random fork and tried to create a PR and got this: Maybe they plan on opening this toggle to everyone in the future? They also have this enabled for creating issues (without disabling them): |
@nihaals That's from "Interaction limits" in settings. But this also prevents users from making issues or even comments on issues. (Which could work for read-only mirrors on GitHub, but that's not the use case for this issue.) |
I can see the interaction limits on one of my repos. I would love to have some more granular control with interaction limits, for example in my case I want to restrict pull requests but leave issues open. |
Under settings, you can disable issues.
Also allow disabling only pull requests but not issues for projects that prefer other review mechanisms like Gerrit, but still want the GH issue tracker.
Related: dear-github/dear-github#84
Edit: reply:
The text was updated successfully, but these errors were encountered: