Replace deprecated String.prototype.substr() #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() or substring() which work similarily but aren't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
isaacs
reviewed
Mar 15, 2022
| sp = this.parse(cs, SUBPARSE) | ||
| re = re.substr(0, reClassStart) + '\\[' + sp[0] | ||
| re = re.substring(0, reClassStart) + '\\[' + sp[0] |
There was a problem hiding this comment.
Why substring here, and not slice?
There was a problem hiding this comment.
reClassStart could be -1, in that case substring() will return an empty string like substr(), slice() however would return everything from the start until the second last char. This would be a different behaviour than we currently have.
'example'.slice(0, -1) == 'exampl'
'example'.substring(0, -1) == ''
'example'.substr(0, -1) == ''
I generally like slice() more as it's stricter and doesn't switch args around but in this case it's not the right tool to use to have the same result as substr().
lamweili
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() or String.prototype.substring() which work similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.