-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slashes don't work inside logic operators #278
Comments
It is correct that slashes do not work inside of extglob patterns such as That being said, you have found a bug here, because it should not throw if you use a pattern like that. |
I was trying to implement something like gitignore, with a set of filtered patterns. Isn't there a way to do that with |
You can take a look at how fstream-ignore does it. That's what npm uses for .npmignore files. https://github.com/npm/fstream-ignore |
On 08/04/2016 01:40 AM, isaacs wrote:
|
There were some magic numbers that assumed that every extglob pattern starts and ends with a specific number of characters in the regular expression. Since !(||) patterns are a little bit more complicated, this led to creating an invalid regular expression and throwing. Fixes isaacs/node-glob#278
Handle extremely long and terrible patterns more gracefully. There were some magic numbers that assumed that every extglob pattern starts and ends with a specific number of characters in the regular expression. Since !(||) patterns are a little bit more complicated, this led to creating an invalid regular expression and throwing. (isaacs/node-glob#278) Credit: @isaacs
There were some magic numbers that assumed that every extglob pattern starts and ends with a specific number of characters in the regular expression. Since !(||) patterns are a little bit more complicated, this led to creating an invalid regular expression and throwing. Fixes isaacs/node-glob#278
For instance, querying the following
will throw this error:
The text was updated successfully, but these errors were encountered: