Remove unnecessary umask calls

Legacy fix for #22 Re nodejs/node#32321
isaacs · Apr 3, 2020 · bea6382 · bea6382
1 parent 42a012c
commit bea6382
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 32 deletions.
diff --git a/index.js b/index.js
@@ -17,7 +17,7 @@ function mkdirP (p, opts, f, made) {
     var xfs = opts.fs || fs;
 
     if (mode === undefined) {
-        mode = _0777 & (~process.umask());
+        mode = _0777
     }
     if (!made) made = null;
 
@@ -62,7 +62,7 @@ mkdirP.sync = function sync (p, opts, made) {
     var xfs = opts.fs || fs;
 
     if (mode === undefined) {
-        mode = _0777 & (~process.umask());
+        mode = _0777
     }
     if (!made) made = null;
 

diff --git a/readme.markdown b/readme.markdown
@@ -37,7 +37,7 @@ Create a new directory and any necessary subdirectories at `dir` with octal
 permission string `opts.mode`. If `opts` is a non-object, it will be treated as
 the `opts.mode`.
 
-If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
+If `opts.mode` isn't specified, it defaults to `0777`.
 
 `cb(err, made)` fires with the error or the first directory `made`
 that had to be created, if any.
@@ -52,7 +52,7 @@ Synchronously create a new directory and any necessary subdirectories at `dir`
 with octal permission string `opts.mode`. If `opts` is a non-object, it will be
 treated as the `opts.mode`.
 
-If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
+If `opts.mode` isn't specified, it defaults to `0777`.
 
 Returns the first directory that had to be created, if any.
 

diff --git a/test/umask.js b/test/umask.js